Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use <img loading="lazy"> instead of react-lazy-load-image-component #8790

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 6, 2024

There is a standard way to defer image loading until they become visible. Use that instead of a React plugin.

More details: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#loading

@emersion emersion requested review from Math-R and theocrsb September 6, 2024 09:32
@emersion emersion requested a review from a team as a code owner September 6, 2024 09:32
@emersion emersion self-assigned this Sep 6, 2024
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion
Copy link
Member Author

Gentle ping @Math-R

Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff !

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

…onent

There is a standard way to defer image loading until they become
visible. Use that instead of a React plugin.

More details: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#loading
@emersion emersion force-pushed the emr/img-lazy-loading branch from 2a30fda to 25a05fc Compare September 13, 2024 10:25
@emersion emersion enabled auto-merge September 13, 2024 10:26
@emersion emersion added this pull request to the merge queue Sep 13, 2024
Merged via the queue into dev with commit 66adf79 Sep 13, 2024
23 checks passed
@emersion emersion deleted the emr/img-lazy-loading branch September 13, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants