-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustment of STDCM interface (Part 1) #8804
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8804 +/- ##
============================================
+ Coverage 36.97% 37.01% +0.04%
- Complexity 2208 2212 +4
============================================
Files 1255 1253 -2
Lines 113846 113882 +36
Branches 3188 3188
============================================
+ Hits 42099 42158 +59
+ Misses 69852 69828 -24
- Partials 1895 1896 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f501758
to
a755f4e
Compare
In the mockup, the consist and itinerary forms have fixed widths, while the map is responsive. Signed-off-by: nncluzu <[email protected]>
The Select component from ui-core defines a custom-select CSS class, which conflicts with Bootstrap's class of the same name. For now, we override the Bootstrap class with the ui-core version, pending a rename in ui-core. Signed-off-by: nncluzu <[email protected]>
a755f4e
to
2bbfb33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR ! Consist/itinerary and blue>black label fixes are good for me but still have some issues with the select one.
382f090
to
93b830b
Compare
…ons displayed Signed-off-by: nncluzu <[email protected]>
93b830b
to
7e6d45a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
In consist component, like 'tracion engine', 'speed limits' and 'composition code' should be bold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There are some differences between mockup and the STDCM interface implementation. This PR fix three of them