Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix map waypoints not displayed in speedspace chart an output … #8858

Conversation

SharglutDev
Copy link
Contributor

…table

Add an util to centralize the insertion of map waypoints in an operational points array

fix #8845
fix #8846

@SharglutDev SharglutDev requested a review from a team as a code owner September 12, 2024 17:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.91398% with 41 lines in your changes missing coverage. Please review.

Project coverage is 36.99%. Comparing base (0412b33) to head (2cb96c3).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/applications/operationalStudies/utils.ts 15.78% 16 Missing ⚠️
...s/helpers/upsertMapWaypointsInOperationalPoints.ts 87.27% 0 Missing and 7 partials ⚠️
...TimeChart/useGetProjectedTrainOperationalPoints.ts 0.00% 7 Missing ⚠️
...t/components/SpeedSpaceChart/useSpeedSpaceChart.ts 0.00% 7 Missing ⚠️
front/scripts/i18n-checker.ts 0.00% 2 Missing ⚠️
...lationResult/components/SpeedSpaceChart/helpers.ts 33.33% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8858      +/-   ##
============================================
+ Coverage     36.96%   36.99%   +0.02%     
  Complexity     2211     2211              
============================================
  Files          1256     1257       +1     
  Lines        114423   114466      +43     
  Branches       3182     3190       +8     
============================================
+ Hits          42295    42341      +46     
+ Misses        70237    70226      -11     
- Partials       1891     1899       +8     
Flag Coverage Δ
core 74.84% <ø> (ø)
editoast 72.43% <ø> (-0.02%) ⬇️
front 14.97% <55.91%> (+0.06%) ⬆️
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/fix-map-waypoints-not-in-speedspacechart-and-outputtable branch from 13322d1 to 8b46b92 Compare September 13, 2024 11:46
@SharglutDev SharglutDev requested a review from clarani September 16, 2024 12:57
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️ Thanks for this PR 🤩

@SharglutDev SharglutDev force-pushed the pfn/front/fix-map-waypoints-not-in-speedspacechart-and-outputtable branch from 616e79c to b304b76 Compare September 17, 2024 08:57
…table

Add an util to centralize the insertion of map waypoints in an operational points array

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the pfn/front/fix-map-waypoints-not-in-speedspacechart-and-outputtable branch from b304b76 to 2cb96c3 Compare September 17, 2024 12:11
@SharglutDev SharglutDev added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Sep 17, 2024
Merged via the queue into dev with commit f1665a2 Sep 17, 2024
23 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-map-waypoints-not-in-speedspacechart-and-outputtable branch September 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants