-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: select only valid train by default (for the selected train and for the train used for the projection) #8879
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8879 +/- ##
============================================
- Coverage 37.14% 37.13% -0.02%
Complexity 2211 2211
============================================
Files 1260 1260
Lines 115060 115084 +24
Branches 3230 3230
============================================
- Hits 42738 42733 -5
- Misses 70389 70418 +29
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c4f3b17
to
5e7aa97
Compare
front/src/applications/operationalStudies/hooks/useSelectedTrainAndPathForProjection.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSelectedTrainAndPathForProjection.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSelectedTrainAndPathForProjection.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSelectedTrainAndPathForProjection.ts
Outdated
Show resolved
Hide resolved
isn’t this this issue ? |
front/src/applications/operationalStudies/hooks/useAutoUpdateProjection.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useAutoUpdateProjection.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useAutoUpdateProjection.ts
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useAutoUpdateProjection.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
By default, we select the first train for the selected train and the path used for the projection, even if it is invalid. However, we should only select a valid train.
af880ac
to
8b35bd9
Compare
Question: do we still allow to select a path for an invalid train schedule ? I would imagine disabling the button for invalid train schedules Enregistrement.de.l.ecran.2024-09-19.120427.mp4 |
@louisgreiner I've created a new issue (#8922) to tackle what you have raised, since we don't agree on how to do it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
closes #8535
To test, create a scenario which contains invalid and valid trains (the first train must be invalid). By default, the train used for the projection should not be the first one