Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: re-enable dependabot for direct dependencies #8990

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 25, 2024

In #2969, dependabot got disabled because it was too spammy. However, disabling dependency updates makes us fall behind pretty hard and makes version upgrades quite painful. Instead of gradually integrating new dependency upgrades and finding bugs as they arise, we're forced to make a huge commit upgrading many packages at once. Regressions are harder to narrow down and humans have to remember and volunteer to perform this unrewarding upgrade task.

As a middle ground, re-enable dependabot updates for direct dependencies only, and group all updates in a single weekly PR. This should make it less spammy than enabling it for all dependencies (transitive dependencies included), while at the same time allowing us to keep up with new versions of libraries we're using.

@emersion emersion requested a review from a team as a code owner September 25, 2024 09:21
@anisometropie
Copy link
Contributor

isn’t there a way to batch all the bumps into one single PR, like every week one big bump PR with all the new cool stuff?

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also changing the frequency to "weekly" instead of "daily", this might also help with the "too noisy" problem and still be acceptable?

@emersion emersion force-pushed the emr/reenable-dependabot branch from ba4ca12 to bd0ec98 Compare September 25, 2024 09:47
@emersion
Copy link
Member Author

Switched to weekly updates grouped in a single PR.

@emersion
Copy link
Member Author

If it's a single weekly PR, maybe we can re-enable updates for transitive dependencies.

@anisometropie
Copy link
Contributor

If it's a single weekly PR, maybe we can re-enable updates for transitive dependencies.

I’d say go for it

In #2969, dependabot got disabled because it was too spammy.
However, disabling dependency updates makes us fall behind pretty
hard and makes version upgrades quite painful. Instead of gradually
integrating new dependency upgrades and finding bugs as they arise,
we're forced to make a huge commit upgrading many packages at once.
Regressions are harder to narrow down and humans have to remember
and volunteer to perform this unrewarding upgrade task.

As a middle ground, re-enable dependabot but group all updates in a
single weekly PR. This should make it less spammy than getting one
PR per dependency upgrade (transitive dependencies included), while
at the same time allowing us to keep up with new versions of
libraries we're using.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion force-pushed the emr/reenable-dependabot branch from bd0ec98 to 4b00d76 Compare September 25, 2024 12:51
@emersion
Copy link
Member Author

Alrighty

@emersion emersion added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@emersion emersion added this pull request to the merge queue Sep 25, 2024
Merged via the queue into dev with commit 748e7cb Sep 25, 2024
24 checks passed
@emersion emersion deleted the emr/reenable-dependabot branch September 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants