front: separate StdcmPathStep and PathStep types #9129

clarani · 2024-10-01T08:39:18Z

⚠️ you will need to clean your local storage to test this PR since I modified the store (or modify all the fields). You may need to clean your local storage also when you will leave my branch

codecov-commenter · 2024-10-01T13:09:20Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.14062% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (c6daa01) to head (0f877cf).
Report is 6 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/reducers/index.ts	50.00%	6 Missing ⚠️
.../reducers/osrdconf/operationalStudiesConf/index.ts	57.14%	6 Missing ⚠️
front/src/utils/timeManipulation.ts	33.33%	2 Missing ⚠️
front/src/reducers/osrdconf/types.ts	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #9129   +/-   ##
=======================================
  Coverage   79.81%   79.82%           
=======================================
  Files        1053     1054    +1     
  Lines      105485   105544   +59     
  Branches      727      727           
=======================================
+ Hits        84198    84248   +50     
- Misses      21245    21254    +9     
  Partials       42       42

Flag	Coverage Δ
editoast	`73.71% <ø> (-0.03%)`	⬇️
front	`89.14% <94.14%> (+<0.01%)`	⬆️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.50% <ø> (ø)`
tests	`87.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

front/src/reducers/osrdconf/types.ts

Synar

LGTM

front/src/reducers/index.ts

front/src/reducers/osrdconf/types.ts

front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx

front/src/applications/stdcm/utils/index.ts

front/src/modules/pathfinding/helpers/getStepLocation.ts

emersion

Just two nits, looks good to me!

front/src/utils/date.ts

front/src/applications/stdcm/components/StdcmForm/StdcmConfig.tsx

front/src/applications/stdcm/components/StdcmForm/StdcmVias.tsx

front/tests/assets/stdcm/stdcmAllStops.json

…udies one Move the actions upsertViaFromSuggestedOP and upsertSeveralViasFromSuggestedOP. Signed-off-by: Clara Ni <[email protected]>

Signed-off-by: Clara Ni <[email protected]>

- completely separate StdcmPathStep and PathStep types - remove all the fake uic path item location (which were equal to -1) - add a transformer in the persist config so the date are correctly deserialized from the local storage Signed-off-by: Clara Ni <[email protected]>

Signed-off-by: Clara Ni <[email protected]>

clarani requested a review from a team as a code owner October 1, 2024 08:39

clarani marked this pull request as draft October 1, 2024 13:05

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from 2f4d327 to b75559b Compare October 1, 2024 13:06

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from b75559b to 2179ccb Compare October 7, 2024 07:34

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from 2179ccb to d242e0d Compare November 15, 2024 15:37

clarani changed the title ~~front: refacto stdcm store~~ front: separate StdcmPathStep and PathStep types Nov 15, 2024

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from d242e0d to a74fa54 Compare November 15, 2024 16:23

github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:gateway labels Nov 18, 2024

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from b9eca3c to e7e1857 Compare November 18, 2024 10:26

github-actions bot removed area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:gateway labels Nov 18, 2024

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch 2 times, most recently from e3dff86 to 8463e56 Compare November 18, 2024 11:19

clarani marked this pull request as ready for review November 18, 2024 13:31

clarani requested review from Synar, SharglutDev and emersion and removed request for SharglutDev November 18, 2024 13:31

SharglutDev reviewed Nov 18, 2024

View reviewed changes

front/src/reducers/osrdconf/types.ts Outdated Show resolved Hide resolved

clarani force-pushed the cni/8986-fix-stdcm-ch-2 branch from 8463e56 to 4754ed0 Compare November 20, 2024 10:08

Synar approved these changes Nov 21, 2024

View reviewed changes