-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: remove the space curves slopes chart #9148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9148 +/- ##
============================================
+ Coverage 37.16% 37.60% +0.43%
Complexity 2242 2242
============================================
Files 1262 1256 -6
Lines 115857 115122 -735
Branches 3278 3271 -7
============================================
+ Hits 43055 43287 +232
+ Misses 70848 69889 -959
+ Partials 1954 1946 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, nice to see all this cleaning :) Left a few comments for possible unused things, feel free to resolve them :)
front/src/modules/simulationResult/components/ChartHelpers/__tests__/ChartHelpers.spec.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/ChartHelpers.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrainDetails.tsx
seems needing some clean
Note we stil use D3js mainly for bisect util functions, we should talk about that and see if we keep the whole lib for that or find another way |
Signed-off-by: Clara Ni <[email protected]>
I totally agree with you @Yohh. We can create a new ticket for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8facc1f
to
b3255b1
Compare
closes #9146