Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove the space curves slopes chart #9148

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 2, 2024

closes #9146

@clarani clarani requested a review from a team as a code owner October 2, 2024 07:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.60%. Comparing base (fd92012) to head (b3255b1).
Report is 29 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9148      +/-   ##
============================================
+ Coverage     37.16%   37.60%   +0.43%     
  Complexity     2242     2242              
============================================
  Files          1262     1256       -6     
  Lines        115857   115122     -735     
  Branches       3278     3271       -7     
============================================
+ Hits          43055    43287     +232     
+ Misses        70848    69889     -959     
+ Partials       1954     1946       -8     
Flag Coverage Δ
core 74.78% <ø> (-0.02%) ⬇️
editoast 72.09% <ø> (-0.46%) ⬇️
front 15.58% <100.00%> (+0.38%) ⬆️
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tested

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, nice to see all this cleaning :) Left a few comments for possible unused things, feel free to resolve them :)

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TrainDetails.tsx seems needing some clean

@Yohh
Copy link
Contributor

Yohh commented Oct 2, 2024

Note

we stil use D3js mainly for bisect util functions, we should talk about that and see if we keep the whole lib for that or find another way

@clarani
Copy link
Contributor Author

clarani commented Oct 3, 2024

I totally agree with you @Yohh. We can create a new ticket for that.

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarani clarani force-pushed the cni/9146-remove-space-curve-slopes branch from 8facc1f to b3255b1 Compare October 3, 2024 07:53
@clarani clarani enabled auto-merge October 3, 2024 07:54
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Oct 3, 2024
@clarani clarani added this pull request to the merge queue Oct 3, 2024
Merged via the queue into dev with commit 818de9c Oct 3, 2024
24 checks passed
@clarani clarani deleted the cni/9146-remove-space-curve-slopes branch October 3, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: remove the SpaceCurveSlopes
5 participants