editoast: provide details when pathfinding failed #9162

younesschrifi · 2024-10-02T21:03:24Z

codecov-commenter · 2024-10-02T21:07:31Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 22.93578% with 84 lines in your changes missing coverage. Please review.

Project coverage is 39.06%. Comparing base (698b8f4) to head (914365c).
Report is 35 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/src/views/path/pathfinding.rs	22.58%	48 Missing ⚠️
...nt/src/modules/pathfinding/hooks/usePathfinding.ts	0.00%	15 Missing ⚠️
editoast/src/views/train_schedule.rs	0.00%	10 Missing ⚠️
...nalStudies/helpers/formatTrainScheduleSummaries.ts	0.00%	5 Missing ⚠️
editoast/src/views/timetable/stdcm.rs	0.00%	2 Missing ⚠️
...dules/trainschedule/components/Timetable/consts.ts	0.00%	1 Missing and 1 partial ⚠️
...odules/trainschedule/components/Timetable/types.ts	0.00%	1 Missing ⚠️
...odules/trainschedule/components/Timetable/utils.ts	0.00%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #9162      +/-   ##
============================================
- Coverage     39.13%   39.06%   -0.08%     
- Complexity     2267     2270       +3     
============================================
  Files          1305     1308       +3     
  Lines         99068    99315     +247     
  Branches       3310     3316       +6     
============================================
+ Hits          38771    38796      +25     
- Misses        58336    58554     +218     
- Partials       1961     1965       +4

Flag	Coverage Δ
core	`74.99% <100.00%> (+0.02%)`	⬆️
editoast	`71.89% <28.57%> (-0.13%)`	⬇️
front	`10.32% <0.00%> (-0.04%)`	⬇️
gateway	`2.50% <ø> (ø)`
osrdyne	`3.29% <ø> (-0.01%)`	⬇️
railjson_generator	`87.49% <ø> (ø)`
tests	`86.71% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

woshilapin

In general, I realize that every (or almost every) struct in the module pathfinding are prefixed with Pathfinding which is somewhat redundant. We might want to fix that but in another PR (hence I put a comment that don't need to be resolved). cc @leovalais

Apart from that, thank you for this PR, I'm always amazed by what this application will bring to debuggability of pathfinding (and simulation) errors.

editoast/src/core/pathfinding.rs

leovalais

Thanks for this PR! LGTM on the views side, but I think there's too much logic in the core module. I agree with @woshilapin about the redundancy of the prefix, and I'm fine with changing that in another PR. I'll test this later.

editoast/src/core/pathfinding.rs

editoast/src/views/path/pathfinding.rs

Akctarus

Tested, left few comments

front/public/locales/en/operationalStudies/scenario.json

front/src/modules/pathfinding/hooks/usePathfinding.ts

Akctarus

LGTM for the front part, not tested yet

Akctarus

LGTM

SharglutDev

Tested and it works great ! Left some comment

front/src/common/api/generatedEditoastApi.ts

front/public/locales/fr/operationalStudies/scenario.json

front/public/locales/en/operationalStudies/scenario.json

front/public/locales/en/operationalStudies/manageTrainSchedule.json

front/src/modules/trainschedule/components/Timetable/consts.ts

Erashin

Core part was very complex, good job navigating through it, thanks for that.. :D

SharglutDev

Lgtm and tested, good job. You can resolve the last 2 comments when needed :)

front/public/locales/en/operationalStudies/scenario.json

leovalais

LGTM, thanks for the changes! A few last modifications 🙏:

editoast/src/core/pathfinding.rs

editoast/src/views/path/pathfinding.rs

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>

github-actions bot added the area:editoast Work on Editoast Service label Oct 2, 2024

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 8 times, most recently from c72891a to 124328d Compare October 10, 2024 21:53

younesschrifi marked this pull request as ready for review October 11, 2024 12:53

younesschrifi requested review from a team as code owners October 11, 2024 12:53

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch from 124328d to 17485fe Compare October 11, 2024 12:57

woshilapin approved these changes Oct 14, 2024

View reviewed changes

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 5 times, most recently from 2e1289d to 5f6ad70 Compare October 15, 2024 07:42

woshilapin approved these changes Oct 15, 2024

View reviewed changes

editoast/src/core/pathfinding.rs Outdated Show resolved Hide resolved

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch from 5f6ad70 to 484797d Compare October 15, 2024 12:30

younesschrifi requested a review from a team as a code owner October 15, 2024 12:30

younesschrifi requested a review from eckter October 15, 2024 12:30

leovalais requested changes Oct 15, 2024

View reviewed changes

editoast/src/core/pathfinding.rs Outdated Show resolved Hide resolved

editoast/src/core/pathfinding.rs Show resolved Hide resolved

editoast/src/core/pathfinding.rs Outdated Show resolved Hide resolved

editoast/src/views/path/pathfinding.rs Outdated Show resolved Hide resolved

Akctarus reviewed Oct 15, 2024

View reviewed changes

front/public/locales/en/operationalStudies/scenario.json Outdated Show resolved Hide resolved

front/src/modules/pathfinding/hooks/usePathfinding.ts Outdated Show resolved Hide resolved

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 4 times, most recently from bc525a8 to 068286f Compare October 17, 2024 10:15

younesschrifi requested a review from Akctarus October 18, 2024 09:58

Akctarus approved these changes Oct 18, 2024

View reviewed changes

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 4 times, most recently from c57e33a to 58107e9 Compare October 21, 2024 15:17

younesschrifi requested review from SharglutDev and leovalais October 21, 2024 15:18

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 2 times, most recently from 3002043 to eb54577 Compare October 21, 2024 15:24

Akctarus approved these changes Oct 21, 2024

View reviewed changes

SharglutDev requested changes Oct 22, 2024

View reviewed changes

Erashin approved these changes Oct 22, 2024

View reviewed changes

younesschrifi requested review from SharglutDev and removed request for eckter October 22, 2024 14:49

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch from b61e346 to bdf6115 Compare October 22, 2024 15:11

SharglutDev approved these changes Oct 23, 2024

View reviewed changes

front/public/locales/en/operationalStudies/scenario.json Outdated Show resolved Hide resolved

leovalais approved these changes Oct 23, 2024

View reviewed changes

editoast/src/core/pathfinding.rs Outdated Show resolved Hide resolved

editoast/src/core/pathfinding.rs Show resolved Hide resolved

editoast/src/views/path/pathfinding.rs Outdated Show resolved Hide resolved

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch 2 times, most recently from ecb8a3b to e28f952 Compare October 23, 2024 19:57

younesschrifi enabled auto-merge October 23, 2024 19:58

younesschrifi added 3 commits October 23, 2024 22:05

editoast: provide details when pathfinding failed

0f56a43

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>

front: adapt front

5d6e101

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>

core: adapt pathfinding error name

914365c

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>

younesschrifi force-pushed the yci/provide_details_to_pathfinding_not_found branch from e28f952 to 914365c Compare October 23, 2024 20:05

younesschrifi added this pull request to the merge queue Oct 23, 2024

Merged via the queue into dev with commit 74968f6 Oct 23, 2024
24 checks passed

younesschrifi deleted the yci/provide_details_to_pathfinding_not_found branch October 23, 2024 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

editoast: provide details when pathfinding failed #9162

editoast: provide details when pathfinding failed #9162

younesschrifi commented Oct 2, 2024 •

edited

Loading

codecov-commenter commented Oct 2, 2024 •

edited

Loading

woshilapin left a comment

leovalais left a comment

Akctarus left a comment

Akctarus left a comment

Akctarus left a comment

SharglutDev left a comment

Erashin left a comment

SharglutDev left a comment

leovalais left a comment

editoast: provide details when pathfinding failed #9162

editoast: provide details when pathfinding failed #9162

Conversation

younesschrifi commented Oct 2, 2024 • edited Loading

codecov-commenter commented Oct 2, 2024 • edited Loading

Codecov Report

woshilapin left a comment

Choose a reason for hiding this comment

leovalais left a comment

Choose a reason for hiding this comment

Akctarus left a comment

Choose a reason for hiding this comment

Akctarus left a comment

Choose a reason for hiding this comment

Akctarus left a comment

Choose a reason for hiding this comment

SharglutDev left a comment

Choose a reason for hiding this comment

Erashin left a comment

Choose a reason for hiding this comment

SharglutDev left a comment

Choose a reason for hiding this comment

leovalais left a comment

Choose a reason for hiding this comment

younesschrifi commented Oct 2, 2024 •

edited

Loading

codecov-commenter commented Oct 2, 2024 •

edited

Loading