Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect location of the conflict list #9172

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 3, 2024

closes #9171

@theocrsb theocrsb requested a review from a team as a code owner October 3, 2024 12:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.53%. Comparing base (0f97f32) to head (7b5e099).
Report is 28 commits behind head on dev.

Files with missing lines Patch % Lines
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9172   +/-   ##
=========================================
  Coverage     37.53%   37.53%           
  Complexity     2242     2242           
=========================================
  Files          1256     1256           
  Lines        114937   114937           
  Branches       3271     3271           
=========================================
+ Hits          43141    43142    +1     
+ Misses        69850    69849    -1     
  Partials       1946     1946           
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.05% <ø> (+<0.01%) ⬆️
front 15.57% <0.00%> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, all well

@theocrsb theocrsb added this pull request to the merge queue Oct 7, 2024
Merged via the queue into dev with commit 63b3516 Oct 7, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/bug-list-conflicts branch October 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect location of the conflict list
4 participants