Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix odd display of filter panel in the timetable train #9184

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 3, 2024

closes #9183

@theocrsb theocrsb requested review from clarani and Caracol3 October 3, 2024 13:43
@theocrsb theocrsb requested a review from a team as a code owner October 3, 2024 13:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (63b3516) to head (2378663).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9184      +/-   ##
============================================
- Coverage     36.91%   36.90%   -0.02%     
  Complexity     2242     2242              
============================================
  Files          1255     1255              
  Lines        116958   116958              
  Branches       3270     3270              
============================================
- Hits          43177    43159      -18     
- Misses        71836    71854      +18     
  Partials       1945     1945              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.20% <ø> (-0.07%) ⬇️
front 15.61% <ø> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.46% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug-odd-display-timetable branch from d00fcc4 to 2378663 Compare October 7, 2024 17:14
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb added this pull request to the merge queue Oct 8, 2024
Merged via the queue into dev with commit 97222e7 Oct 8, 2024
25 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/bug-odd-display-timetable branch October 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd display in the timetable train
4 participants