Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix the issue where the 'More details' button stopped working #9227

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes #9181

@achrafmohye achrafmohye requested a review from a team as a code owner October 7, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.15%. Comparing base (a815c8a) to head (10a7a42).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9227      +/-   ##
============================================
- Coverage     39.15%   39.15%   -0.01%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97277    97278       +1     
  Branches       3280     3280              
============================================
- Hits          38092    38086       -6     
- Misses        57246    57253       +7     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.45% <ø> (-0.03%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was a regression, maybe we need a test to avoid another regression later?

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped functionning Fix the issue where the 'More details' button stopped functioning Oct 8, 2024
@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped functioning Fix the issue where the 'More details' button stopped working Oct 8, 2024
@woshilapin woshilapin changed the title Fix the issue where the 'More details' button stopped working front: fix the issue where the 'More details' button stopped working Oct 8, 2024
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theocrsb theocrsb requested a review from SharglutDev October 10, 2024 11:52
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani
Copy link
Contributor

clarani commented Oct 11, 2024

@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :)

@Maymanaf
Copy link
Contributor

@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :)

The timetable management tests are planned but not prioritized for now : You can check the order #7706

@achrafmohye achrafmohye force-pushed the ame/fix-train-list-more-details-button branch from fbafd33 to 96018b9 Compare October 14, 2024 15:29
…ing in the train list.

Signed-off-by: Achraf Mohyeddine <[email protected]>
@achrafmohye achrafmohye force-pushed the ame/fix-train-list-more-details-button branch from 96018b9 to 10a7a42 Compare October 14, 2024 15:35
@achrafmohye achrafmohye enabled auto-merge October 14, 2024 15:52
@achrafmohye achrafmohye added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@achrafmohye achrafmohye added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@theocrsb theocrsb added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@theocrsb theocrsb added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@theocrsb theocrsb added this pull request to the merge queue Oct 15, 2024
Merged via the queue into dev with commit 165de7f Oct 15, 2024
24 checks passed
@theocrsb theocrsb deleted the ame/fix-train-list-more-details-button branch October 15, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more details button doesn't work anymore in the train list
7 participants