-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix the issue where the 'More details' button stopped working #9227
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9227 +/- ##
============================================
- Coverage 39.15% 39.15% -0.01%
Complexity 2245 2245
============================================
Files 1290 1290
Lines 97277 97278 +1
Branches 3280 3280
============================================
- Hits 38092 38086 -6
- Misses 57246 57253 +7
Partials 1939 1939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was a regression, maybe we need a test to avoid another regression later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
@woshilapin I think the better way to test this is by an e2e test. The e2e test are planned and developed by @Maymanaf right now, so I think we won't add the test in this PR. But we can do it later, with @Maymanaf :) |
The timetable management tests are planned but not prioritized for now : You can check the order #7706 |
fbafd33
to
96018b9
Compare
…ing in the train list. Signed-off-by: Achraf Mohyeddine <[email protected]>
96018b9
to
10a7a42
Compare
Closes #9181