Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add scenario train ids to query params and local storage #9429

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Oct 22, 2024

Close #9018

@Synar Synar requested a review from a team as a code owner October 22, 2024 15:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 39.05%. Comparing base (8a66782) to head (eb8d0be).
Report is 87 commits behind head on dev.

Files with missing lines Patch % Lines
...operationalStudies/hooks/useScenarioQueryParams.ts 0.00% 63 Missing and 1 partial ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9429      +/-   ##
============================================
- Coverage     39.15%   39.05%   -0.10%     
- Complexity     2245     2267      +22     
============================================
  Files          1290     1309      +19     
  Lines         97316    99260    +1944     
  Branches       3280     3313      +33     
============================================
+ Hits          38100    38768     +668     
- Misses        57277    58528    +1251     
- Partials       1939     1964      +25     
Flag Coverage Δ
core 74.93% <ø> (-0.01%) ⬇️
editoast 72.00% <ø> (-0.48%) ⬇️
front 10.31% <0.00%> (-0.02%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (-0.23%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works like a charm! Thanks :pray :

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! nice work

@Synar Synar added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@Synar Synar added this pull request to the merge queue Oct 24, 2024
Merged via the queue into dev with commit f91b8ec Oct 24, 2024
24 checks passed
@Synar Synar deleted the ali/add-scenario-query-params branch October 24, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the selected train and the projection to the scenario URL
4 participants