Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: add error when input timings aren't possible #9437

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 23, 2024

May help with debugging "no solution found" issues

@eckter eckter requested a review from Erashin October 23, 2024 13:53
@eckter eckter requested a review from a team as a code owner October 23, 2024 13:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.07%. Comparing base (02ea460) to head (ea7231d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...otlin/fr/sncf/osrd/stdcm/graph/STDCMPathfinding.kt 64.70% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9437      +/-   ##
============================================
- Coverage     39.08%   39.07%   -0.01%     
- Complexity     2267     2270       +3     
============================================
  Files          1308     1308              
  Lines         99203    99220      +17     
  Branches       3312     3315       +3     
============================================
- Hits          38774    38772       -2     
- Misses        58466    58484      +18     
- Partials       1963     1964       +1     
Flag Coverage Δ
core 74.99% <66.66%> (-0.01%) ⬇️
editoast 71.97% <ø> (-0.05%) ⬇️
front 10.32% <ø> (ø)
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/add-error-impossible-timings branch from 8e86243 to ea7231d Compare October 23, 2024 14:33
@eckter eckter added this pull request to the merge queue Oct 23, 2024
Merged via the queue into dev with commit f0ab6fa Oct 23, 2024
24 checks passed
@eckter eckter deleted the ech/add-error-impossible-timings branch October 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants