Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orsdyne: add telemetry support #9440

Merged
merged 1 commit into from
Oct 24, 2024
Merged

orsdyne: add telemetry support #9440

merged 1 commit into from
Oct 24, 2024

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Oct 24, 2024

Adding telemetry in osrdyne

closes #8081

@ElysaSrc ElysaSrc requested a review from a team as a code owner October 24, 2024 07:53
@ElysaSrc ElysaSrc requested a review from woshilapin October 24, 2024 07:53
@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch from 9074c04 to f333351 Compare October 24, 2024 07:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (dffb4b0) to head (b4a5766).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
osrdyne/src/drivers/kubernetes.rs 0.00% 18 Missing ⚠️
osrdyne/src/drivers/docker.rs 0.00% 14 Missing ⚠️
osrdyne/src/pool.rs 0.00% 13 Missing ⚠️
osrdyne/src/drivers/process_compose.rs 0.00% 6 Missing ⚠️
osrdyne/src/queue_controller.rs 0.00% 6 Missing ⚠️
osrdyne/src/drivers/noop.rs 0.00% 4 Missing ⚠️
osrdyne/src/api.rs 0.00% 3 Missing ⚠️
osrdyne/src/target_tracker.rs 0.00% 3 Missing ⚠️
osrdyne/src/watch_logger.rs 0.00% 2 Missing ⚠️
osrdyne/src/status_tracker.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9440      +/-   ##
============================================
+ Coverage     39.63%   39.65%   +0.01%     
  Complexity     2270     2270              
============================================
  Files          1301     1301              
  Lines         99071    99003      -68     
  Branches       3284     3284              
============================================
- Hits          39271    39258      -13     
+ Misses        57867    57812      -55     
  Partials       1933     1933              
Flag Coverage Δ
core 74.98% <ø> (ø)
editoast 73.21% <ø> (-0.05%) ⬇️
front 10.23% <ø> (ø)
gateway 2.50% <ø> (ø)
osrdyne 3.29% <0.00%> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch from f333351 to c744f02 Compare October 24, 2024 07:57
@ElysaSrc ElysaSrc changed the title orsdyne: adding telemetry support orsdyne: add telemetry support Oct 24, 2024
@ElysaSrc ElysaSrc mentioned this pull request Oct 24, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add env vars to the host and pr-tests docker-compose files.

Otherwise LGTM

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see more OpenTelemetry everywhere.

You might also want to configure axum so it catches the trace ID in incoming requests. See here. You may also add TraceLayer to automatically create spans on all incoming requests (see

.layer(TraceLayer::new_for_http())
)).

@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch 2 times, most recently from 168e268 to de832e9 Compare October 24, 2024 11:34
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements.

@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch 2 times, most recently from dea37f1 to b2d3c88 Compare October 24, 2024 14:13
@flomonster
Copy link
Contributor

Not working in local. Osrdyne logs:

Error: missing field `service_name` for key "OPENTELEMETRY" in `OSRDYNE__` environment variable(s)

@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch from b2d3c88 to 68450ac Compare October 24, 2024 14:41
@ElysaSrc ElysaSrc force-pushed the ev/osrdyne-telemetry branch from 68450ac to b4a5766 Compare October 24, 2024 14:45
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but looks ok :)

@ElysaSrc ElysaSrc added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@ElysaSrc ElysaSrc added this pull request to the merge queue Oct 24, 2024
Merged via the queue into dev with commit ca461a7 Oct 24, 2024
24 checks passed
@ElysaSrc ElysaSrc deleted the ev/osrdyne-telemetry branch October 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Osrdyne: add telemetry
5 participants