-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orsdyne: add telemetry support #9440
Conversation
9074c04
to
f333351
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9440 +/- ##
============================================
+ Coverage 39.63% 39.65% +0.01%
Complexity 2270 2270
============================================
Files 1301 1301
Lines 99071 99003 -68
Branches 3284 3284
============================================
- Hits 39271 39258 -13
+ Misses 57867 57812 -55
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f333351
to
c744f02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add env vars to the host and pr-tests docker-compose files.
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
168e268
to
de832e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements.
dea37f1
to
b2d3c88
Compare
Not working in local. Osrdyne logs:
|
b2d3c88
to
68450ac
Compare
Signed-off-by: Élyse Viard <[email protected]>
68450ac
to
b4a5766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested but looks ok :)
Adding telemetry in osrdyne
closes #8081