Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add 'label' to towed rolling stock #9465

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Oct 24, 2024

Follow up of #9202. We're missing a long name. I used label.

@woshilapin woshilapin requested a review from a team as a code owner October 24, 2024 15:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (dffb4b0) to head (e66220e).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/models/towed_rolling_stock.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9465      +/-   ##
============================================
- Coverage     39.63%   39.59%   -0.05%     
  Complexity     2270     2270              
============================================
  Files          1301     1300       -1     
  Lines         99071    99154      +83     
  Branches       3284     3282       -2     
============================================
- Hits          39271    39262       -9     
- Misses        57867    57959      +92     
  Partials       1933     1933              
Flag Coverage Δ
core 75.07% <ø> (+0.09%) ⬆️
editoast 73.20% <71.42%> (-0.05%) ⬇️
front 10.23% <ø> (ø)
gateway 2.19% <ø> (-0.31%) ⬇️
osrdyne 3.29% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woshilapin woshilapin force-pushed the wsl/editoast/towed-rolling-stock-description branch from ec7b869 to b45fc6c Compare October 25, 2024 08:35
@woshilapin woshilapin changed the title editoast: add 'description' to towed rolling stock editoast: add 'label' to towed rolling stock Oct 25, 2024
@woshilapin woshilapin force-pushed the wsl/editoast/towed-rolling-stock-description branch from b45fc6c to e66220e Compare October 25, 2024 09:09
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Oct 25, 2024
@woshilapin woshilapin enabled auto-merge October 25, 2024 11:17
@woshilapin woshilapin added this pull request to the merge queue Oct 25, 2024
Merged via the queue into dev with commit 86ad640 Oct 25, 2024
24 checks passed
@woshilapin woshilapin deleted the wsl/editoast/towed-rolling-stock-description branch October 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants