editoast: remove always-on directive #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9478 +/- ##
============================================
- Coverage 39.60% 39.60% -0.01%
Complexity 2270 2270
============================================
Files 1300 1300
Lines 99154 99154
Branches 3282 3282
============================================
- Hits 39270 39268 -2
- Misses 57951 57953 +2
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flomonster
approved these changes
Oct 25, 2024
Good point. Done in 37a05a8. |
This modification was done in order to bring logs for any request that comes in thanks to the `tower_http::trace::TraceLayer` middleware. But the code has a sneaky behavior where it's actually impossible to turn it of anymore. For example, `RUST_LOG=info,tower_http=none` will still show `tower_http` logs. Let's remove it. Signed-off-by: Jean SIMARD <[email protected]>
woshilapin
force-pushed
the
wsl/editoast/remove-http-tower-directive
branch
from
37a05a8 to
7f653ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification was done in order to bring logs for any request that comes in thanks to the
tower_http::trace::TraceLayermiddleware. But the code has a sneaky behavior where it's actually impossible to turn it of anymore.For example,
RUST_LOG=info,tower_http=nonewill still showtower_httplogs.Let's remove it.