-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: redesign map in result page #9481
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9481 +/- ##
============================================
- Coverage 39.77% 39.76% -0.02%
Complexity 2270 2270
============================================
Files 1302 1302
Lines 99546 99565 +19
Branches 3282 3282
============================================
- Hits 39598 39592 -6
- Misses 58016 58041 +25
Partials 1932 1932
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6e34012
to
c21fd7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM, I think STDCM map needs to be updated too to match this redesign. Left 2 comments
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
a3e5742
to
729d1ee
Compare
b535c1c
to
d884aee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will also add the origin/destination markers to the warped map, is it what we want ?
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Show resolved
Hide resolved
Should we ask a PO since @thibautsailly isn't here ? |
I asked to @Tguisnet |
5ae2495
to
5567797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
5567797
to
9feca22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Signed-off-by: theocrsb <[email protected]>
Signed-off-by: theocrsb <[email protected]>
9feca22
to
37a92e4
Compare
There are no real specifications for the warp map, so it's complicated to know what we want to have on it. I think we could merge this PR, there are a lot of adjustements coming soon for the result page, the warp map probably won't follow all of the changes, so we'll have to specify what we want for the warp map, but later. |
closes part of https://github.com/osrd-project/osrd-confidential/issues/670
For the redesign of the buttons I'm going to do another PR because this part is optional and I don't have the mockup.