Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: redesign map in result page #9481

Merged
merged 2 commits into from
Oct 31, 2024
Merged

front: redesign map in result page #9481

merged 2 commits into from
Oct 31, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 28, 2024

closes part of https://github.com/osrd-project/osrd-confidential/issues/670

For the redesign of the buttons I'm going to do another PR because this part is optional and I don't have the mockup.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.76%. Comparing base (a9261bc) to head (37a92e4).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...omponents/SimulationResultsMap/RenderItinerary.tsx 0.00% 24 Missing ⚠️
...hedule/ManageTrainScheduleMap/ItineraryMarkers.tsx 0.00% 3 Missing ⚠️
...ns/stdcm/components/StdcmForm/StdcmDestination.tsx 0.00% 1 Missing ⚠️
...cations/stdcm/components/StdcmForm/StdcmOrigin.tsx 0.00% 1 Missing ⚠️
...lications/stdcm/components/StdcmForm/StdcmVias.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9481      +/-   ##
============================================
- Coverage     39.77%   39.76%   -0.02%     
  Complexity     2270     2270              
============================================
  Files          1302     1302              
  Lines         99546    99565      +19     
  Branches       3282     3282              
============================================
- Hits          39598    39592       -6     
- Misses        58016    58041      +25     
  Partials       1932     1932              
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.55% <ø> (-0.03%) ⬇️
front 10.20% <0.00%> (-0.01%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/redesign-map branch from 6e34012 to c21fd7b Compare October 29, 2024 09:07
@theocrsb theocrsb marked this pull request as ready for review October 29, 2024 10:08
@theocrsb theocrsb requested a review from a team as a code owner October 29, 2024 10:08
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, I think STDCM map needs to be updated too to match this redesign. Left 2 comments

@theocrsb theocrsb force-pushed the tce/front/redesign-map branch from a3e5742 to 729d1ee Compare October 30, 2024 13:16
@theocrsb theocrsb force-pushed the tce/front/redesign-map branch 3 times, most recently from b535c1c to d884aee Compare October 31, 2024 10:12
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will also add the origin/destination markers to the warped map, is it what we want ?

@SharglutDev
Copy link
Contributor

This PR will also add the origin/destination markers to the warped map, is it what we want ?

Should we ask a PO since @thibautsailly isn't here ?

@theocrsb
Copy link
Contributor Author

This PR will also add the origin/destination markers to the warped map, is it what we want ?

Should we ask a PO since @thibautsailly isn't here ?

I asked to @Tguisnet

@theocrsb theocrsb force-pushed the tce/front/redesign-map branch from 5ae2495 to 5567797 Compare October 31, 2024 12:12
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@theocrsb theocrsb requested a review from clarani October 31, 2024 12:15
@theocrsb theocrsb force-pushed the tce/front/redesign-map branch from 5567797 to 9feca22 Compare October 31, 2024 12:19
@SharglutDev
Copy link
Contributor

Actually the map mockup says this :
Capture d’écran 2024-10-31 à 13 25 19
So I think we should also display the vias

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb force-pushed the tce/front/redesign-map branch from 9feca22 to 37a92e4 Compare October 31, 2024 13:11
@Tguisnet
Copy link
Contributor

Tguisnet commented Oct 31, 2024

This PR will also add the origin/destination markers to the warped map, is it what we want ?

There are no real specifications for the warp map, so it's complicated to know what we want to have on it.
But the warp map is currently reversed (from the implementation of the new GET), so at least we could see how its works now with this markers :).

I think we could merge this PR, there are a lot of adjustements coming soon for the result page, the warp map probably won't follow all of the changes, so we'll have to specify what we want for the warp map, but later.

@theocrsb theocrsb added this pull request to the merge queue Oct 31, 2024
Merged via the queue into dev with commit f7f1991 Oct 31, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/redesign-map branch October 31, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants