-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add trigger for search_scenario table population #9484
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9484 +/- ##
============================================
- Coverage 39.65% 39.61% -0.05%
Complexity 2270 2270
============================================
Files 1300 1300
Lines 99008 99167 +159
Branches 3282 3283 +1
============================================
+ Hits 39265 39285 +20
- Misses 57812 57949 +137
- Partials 1931 1933 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with Léo's change)
Signed-off-by: Ethan Perruzza <[email protected]>
72cd5e7
to
20be4f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, to please the CI you'll need to format your commits and run cargo fmt
(probably best to setup you editor to format on save ;)
fixes : #8612 (comment)