Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add trigger for search_scenario table population #9484

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

@EthanPERRUZZA EthanPERRUZZA commented Oct 28, 2024

fixes : #8612 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.61%. Comparing base (2449281) to head (20be4f3).
Report is 98 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/editoast_models/src/tables.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9484      +/-   ##
============================================
- Coverage     39.65%   39.61%   -0.05%     
  Complexity     2270     2270              
============================================
  Files          1300     1300              
  Lines         99008    99167     +159     
  Branches       3282     3283       +1     
============================================
+ Hits          39265    39285      +20     
- Misses        57812    57949     +137     
- Partials       1931     1933       +2     
Flag Coverage Δ
core 75.06% <ø> (+0.06%) ⬆️
editoast 73.27% <0.00%> (+0.03%) ⬆️
front 10.23% <ø> (-0.02%) ⬇️
gateway 2.19% <ø> (-0.31%) ⬇️
osrdyne 3.28% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review October 28, 2024 13:54
@EthanPERRUZZA EthanPERRUZZA requested a review from a team as a code owner October 28, 2024 13:54
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with Léo's change)

@EthanPERRUZZA EthanPERRUZZA self-assigned this Oct 29, 2024
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to please the CI you'll need to format your commits and run cargo fmt (probably best to setup you editor to format on save ;)

@EthanPERRUZZA EthanPERRUZZA added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit 8395021 Nov 7, 2024
24 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/scenario_search_bug branch November 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: cannot search the scenario
4 participants