Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add lazy loader message on GET in stdcm #9490

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 28, 2024

closes #8610

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 37.83%. Comparing base (b4b2d7f) to head (9cde509).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ications/stdcm/hooks/useProjectedTrainsForStdcm.ts 0.00% 8 Missing ⚠️
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 6 Missing ⚠️
...ations/operationalStudies/hooks/useScenarioData.ts 0.00% 4 Missing ⚠️
...tdcm/components/StdcmResults/StdcmDebugResults.tsx 0.00% 4 Missing ⚠️
...nalStudies/components/Scenario/ScenarioContent.tsx 0.00% 2 Missing ⚠️
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9490      +/-   ##
==========================================
- Coverage   37.84%   37.83%   -0.02%     
==========================================
  Files         990      990              
  Lines       90921    90929       +8     
  Branches     1176     1176              
==========================================
- Hits        34412    34401      -11     
- Misses      56055    56074      +19     
  Partials      454      454              
Flag Coverage Δ
editoast 73.23% <ø> (-0.04%) ⬇️
front 20.11% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/8610-lazy-loader-info-stdcm branch 2 times, most recently from 41a52d6 to 4b56067 Compare November 4, 2024 14:22
@clarani clarani marked this pull request as ready for review November 4, 2024 14:23
@clarani clarani requested a review from a team as a code owner November 4, 2024 14:23
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Left just one suggestion, you can resolve yourself after treating it or not :)

@clarani clarani force-pushed the cni/8610-lazy-loader-info-stdcm branch from 90bc2b5 to 8312cdb Compare November 18, 2024 09:16
@clarani clarani enabled auto-merge November 18, 2024 09:16
@clarani clarani force-pushed the cni/8610-lazy-loader-info-stdcm branch from 8312cdb to 9cde509 Compare November 18, 2024 09:23
@clarani clarani added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit a4daa6d Nov 18, 2024
27 checks passed
@clarani clarani deleted the cni/8610-lazy-loader-info-stdcm branch November 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing lazy loader info in STDCM GET
3 participants