Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: hide simulation sticky bar #9512

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

theocrsb
Copy link
Contributor

closes #9511

@theocrsb theocrsb requested a review from a team as a code owner October 29, 2024 15:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.77%. Comparing base (6d9ed21) to head (eb3b41a).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9512      +/-   ##
============================================
+ Coverage     39.65%   39.77%   +0.12%     
  Complexity     2270     2270              
============================================
  Files          1300     1302       +2     
  Lines         99079    99538     +459     
  Branches       3279     3282       +3     
============================================
+ Hits          39286    39588     +302     
- Misses        57864    58018     +154     
- Partials       1929     1932       +3     
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.54% <ø> (+0.22%) ⬆️
front 10.20% <ø> (-0.02%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tested

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but plz add to the issue for the new chart controller that this should be removed

@theocrsb
Copy link
Contributor Author

Lgtm but plz add to the issue for the new chart controller that this should be removed

#9422 (comment)

@theocrsb theocrsb enabled auto-merge October 30, 2024 07:54
@theocrsb theocrsb requested a review from SharglutDev October 31, 2024 12:03
@theocrsb theocrsb force-pushed the tce/front/trainschedule/hide-top-bar branch from 319aaee to eb3b41a Compare October 31, 2024 12:23
@theocrsb theocrsb added this pull request to the merge queue Oct 31, 2024
Merged via the queue into dev with commit 2892c57 Oct 31, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/hide-top-bar branch October 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the simulation-sticky-bar until it's redesigned
4 participants