Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: fix priority between stop and departure delay #9514

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 29, 2024

Fix #9508

@eckter eckter changed the title Ech/departure shift over stops core: stdcm: add test for priority between stop and departure delay Oct 29, 2024
@eckter eckter force-pushed the ech/departure_shift_over_stops branch from c7f5a49 to 04a9bec Compare October 29, 2024 16:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.51%. Comparing base (5eeb926) to head (17d418b).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
...in/fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.kt 83.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9514      +/-   ##
============================================
- Coverage     39.52%   39.51%   -0.01%     
- Complexity     2270     2271       +1     
============================================
  Files          1309     1309              
  Lines        100244   100257      +13     
  Branches       3295     3296       +1     
============================================
- Hits          39622    39621       -1     
- Misses        58677    58690      +13     
- Partials       1945     1946       +1     
Flag Coverage Δ
core 75.06% <94.73%> (-0.01%) ⬇️
editoast 73.54% <ø> (-0.04%) ⬇️
front 10.10% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/departure_shift_over_stops branch from 04a9bec to 72c5d80 Compare October 30, 2024 14:54
@eckter eckter changed the title core: stdcm: add test for priority between stop and departure delay core: stdcm: fix priority between stop and departure delay Oct 31, 2024
@eckter eckter force-pushed the ech/departure_shift_over_stops branch from 72c5d80 to 6ccf21b Compare October 31, 2024 10:25
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests looking good as well.

@eckter eckter force-pushed the ech/departure_shift_over_stops branch 2 times, most recently from c0f46dd to 704003c Compare November 4, 2024 14:34
@eckter eckter marked this pull request as ready for review November 4, 2024 14:40
@eckter eckter requested a review from a team as a code owner November 4, 2024 14:40
@eckter eckter requested a review from Erashin November 4, 2024 14:40
@eckter eckter force-pushed the ech/departure_shift_over_stops branch from 704003c to 17d418b Compare November 4, 2024 14:46
@eckter eckter added this pull request to the merge queue Nov 5, 2024
Merged via the queue into dev with commit ab280f7 Nov 5, 2024
24 checks passed
@eckter eckter deleted the ech/departure_shift_over_stops branch November 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm sometimes fails to find a path for no apparent reason
3 participants