front: use Date in TrainScheduleWithDetails #9518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
commented
Oct 30, 2024
front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx
Outdated
Show resolved
Hide resolved
emersion
force-pushed
the
emr/refacto-timetable-date
branch
from
1fb119a to
cce61b8
Compare
Akctarus
approved these changes
Oct 30, 2024
Instead of passing around formatted strings, pass a Date object. That way we don't need to undo the formatting in TimetableTrainCard later on, and we get improved type safety. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/refacto-timetable-date
branch
from
cce61b8 to
633e09c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing around formatted strings, pass a Date object. That way we don't need to undo the formatting in TimetableTrainCard later on, and we get improved type safety.
No behavior change intended.