Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove all remaining JavaScript files #9521

Merged
merged 1 commit into from
Oct 31, 2024
Merged

front: remove all remaining JavaScript files #9521

merged 1 commit into from
Oct 31, 2024

Conversation

emersion
Copy link
Member

Use TypeScript everywhere.

Make some component properties optional to reflect current usage.

Use TypeScript everywhere.

Make some component properties optional to reflect current usage.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested review from Yohh and SharglutDev October 30, 2024 15:33
@emersion emersion requested a review from a team as a code owner October 30, 2024 15:33
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@emersion emersion removed the request for review from SharglutDev October 31, 2024 10:24
@emersion emersion added this pull request to the merge queue Oct 31, 2024
Merged via the queue into dev with commit 533546c Oct 31, 2024
24 checks passed
@emersion emersion deleted the emr/no-js branch October 31, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants