Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stdcm 0 tolerance value #9522

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

Akctarus
Copy link
Contributor

closes #9450

@Akctarus Akctarus requested a review from a team as a code owner October 30, 2024 16:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (94f41d4) to head (652f3fd).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
...ns/stdcm/components/StdcmForm/StdcmDestination.tsx 0.00% 8 Missing ⚠️
...cations/stdcm/components/StdcmForm/StdcmOrigin.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9522      +/-   ##
============================================
- Coverage     39.66%   39.65%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1300     1300              
  Lines         99011    99037      +26     
  Branches       3279     3279              
============================================
+ Hits          39274    39277       +3     
- Misses        57808    57831      +23     
  Partials       1929     1929              
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.28% <ø> (+0.01%) ⬆️
front 10.23% <0.00%> (-0.01%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@Akctarus Akctarus added this pull request to the merge queue Oct 31, 2024
Merged via the queue into dev with commit a9261bc Oct 31, 2024
24 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-stdcm-tolerance branch October 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select -0/+0 tolerance anymore
4 participants