-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix height NGE tab #9550
Fix height NGE tab #9550
Conversation
- change height in .macro-container Signed-off-by: Uriel Sautron <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9550 +/- ##
============================================
+ Coverage 39.52% 42.50% +2.98%
- Complexity 2270 2271 +1
============================================
Files 1309 1311 +2
Lines 100242 105411 +5169
Branches 3295 3296 +1
============================================
+ Hits 39618 44804 +5186
+ Misses 58679 58661 -18
- Partials 1945 1946 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
469e072
to
1060dcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can you round all the values in px ?
- can you keep rem for the font-size ?
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
Thanks for separating the 2 commits !! 🤩 |
1060dcc
to
05657d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well, but to respect the choice made in the front point, all font sizes must be set to rem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have some font-size in px
Signed-off-by: Uriel Sautron <[email protected]>
05657d0
to
ea3f87f
Compare
Oupss, done thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
close #9231