Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height NGE tab #9550

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix height NGE tab #9550

merged 2 commits into from
Nov 6, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

close #9231

  - change height in .macro-container
Signed-off-by: Uriel Sautron <[email protected]>
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner November 4, 2024 11:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (c3d0409) to head (ea3f87f).
Report is 39 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9550      +/-   ##
============================================
+ Coverage     39.52%   42.50%   +2.98%     
- Complexity     2270     2271       +1     
============================================
  Files          1309     1311       +2     
  Lines        100242   105411    +5169     
  Branches       3295     3296       +1     
============================================
+ Hits          39618    44804    +5186     
+ Misses        58679    58661      -18     
- Partials       1945     1946       +1     
Flag Coverage Δ
core 75.06% <ø> (-0.01%) ⬇️
editoast 73.67% <ø> (+0.10%) ⬆️
front 18.79% <ø> (+8.68%) ⬆️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (+<0.01%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-height-nge-tab branch from 469e072 to 1060dcc Compare November 4, 2024 13:08
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can you round all the values in px ?
  • can you keep rem for the font-size ?

@clarani
Copy link
Contributor

clarani commented Nov 4, 2024

Thanks for separating the 2 commits !! 🤩

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well, but to respect the choice made in the front point, all font sizes must be set to rem

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some font-size in px

@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-height-nge-tab branch from 05657d0 to ea3f87f Compare November 6, 2024 14:28
@Uriel-Sautron
Copy link
Contributor Author

You still have some font-size in px

Oupss, done thank you

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Nov 6, 2024
Merged via the queue into dev with commit bfa5205 Nov 6, 2024
24 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/fix-height-nge-tab branch November 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGE tab is not responsive (scroll bar)
5 participants