-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front, scripts: add playwright container for e2e tests #9554
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9554 +/- ##
============================================
- Coverage 42.49% 37.83% -4.66%
============================================
Files 1312 990 -322
Lines 105608 90920 -14688
Branches 3305 1176 -2129
============================================
- Hits 44878 34400 -10478
+ Misses 58777 56066 -2711
+ Partials 1953 454 -1499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Have you seen this? https://playwright.dev/docs/test-ui-mode#docker--github-codespaces |
I had not, this should be much simpler |
could we put |
I mildly disagree, running the e2e tests shouldn't be a front thing. |
Tested, seems to work perfectly and should greatly simplify the script. Thanks a lot! |
4441531
to
2e97c9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once rebased, this PR totally fixes the known issues about e2e tests while using host-compose.sh
, thank you
76bb43e
to
fc83bde
Compare
A bit outside the scope of this pr, but I noticed that the CI seems to spend a lot of time installing playwright deps with "npx playwright install --with-deps". Could we accelerate this using a microsoft/playwright based image, similar to what is done here? |
Potentially. A lot of the time is network transfer though, so it might not be much faster. Do you want to do it? |
Sure. We can even reuse Dockerfile.playwright wholesale right? I'll do this in another PR though |
fc83bde
to
33df660
Compare
Signed-off-by: Alice Khoudli <[email protected]>
33df660
to
b8d7488
Compare
Close #9505
Instead of simply expanding the readme as initially thought in the issue,
a dockerfile is added for the playwright container,
and a script is used to launch it with optional ui flags for x11 and wayland.
The wayland flag is currently not working (hence the draft status), but the headless and x11 mode are working and ready for review. Interestingly, the x11 mode works on wayland through compatibility.