-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add vias in simulation results map and warped map #9555
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9555 +/- ##
==========================================
+ Coverage 37.80% 38.11% +0.31%
==========================================
Files 994 995 +1
Lines 91171 91697 +526
Branches 1174 1193 +19
==========================================
+ Hits 34464 34953 +489
- Misses 56253 56290 +37
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eda0b3b
to
7abc080
Compare
front/src/modules/simulationResult/components/SimulationResultsMap/SimulationResultsMap.tsx
Outdated
Show resolved
Hide resolved
7abc080
to
c5031ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great, left some comments for improving.
We still have one weird behavior though. If we have 2 vias very close and we are at a low zoom, the second one is hiding the first. But we have the same issue on the ManageTrainSchedule
map. We should check that with @thibautsailly to fix it in another PR for both maps.
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
ac1634d
to
4eb02ab
Compare
Signed-off-by: Theo Macron <[email protected]>
4eb02ab
to
d4ade2e
Compare
closes #9541
Vias should be displayed as on the STDCM map.
Note: Warped map don't handle vias on this PR. Itinerary markers are displayed with a gap on the wrap-around map, and also since the path is mostly vertical, displaying vias risks significantly reducing the visibility of the route.