Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add vias in simulation results map and warped map #9555

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 4, 2024

closes #9541

Vias should be displayed as on the STDCM map.

Note: Warped map don't handle vias on this PR. Itinerary markers are displayed with a gap on the wrap-around map, and also since the path is mostly vertical, displaying vias risks significantly reducing the visibility of the route.

@Akctarus Akctarus requested a review from a team as a code owner November 4, 2024 16:38
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 38.11%. Comparing base (46aa74f) to head (d4ade2e).
Report is 23 commits behind head on dev.

Files with missing lines Patch % Lines
...omponents/SimulationResultsMap/RenderItinerary.tsx 0.00% 20 Missing and 1 partial ⚠️
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 8 Missing ⚠️
...ents/SimulationResultsMap/SimulationResultsMap.tsx 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9555      +/-   ##
==========================================
+ Coverage   37.80%   38.11%   +0.31%     
==========================================
  Files         994      995       +1     
  Lines       91171    91697     +526     
  Branches     1174     1193      +19     
==========================================
+ Hits        34464    34953     +489     
- Misses      56253    56290      +37     
  Partials      454      454              
Flag Coverage Δ
editoast 73.24% <ø> (+0.22%) ⬆️
front 20.20% <0.00%> (+0.12%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/simulation-results-maps-vias branch 2 times, most recently from eda0b3b to 7abc080 Compare November 6, 2024 10:19
@Akctarus Akctarus force-pushed the tmn/front/simulation-results-maps-vias branch from 7abc080 to c5031ce Compare November 20, 2024 09:56
@Akctarus Akctarus requested a review from SharglutDev November 20, 2024 13:54
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great, left some comments for improving.

We still have one weird behavior though. If we have 2 vias very close and we are at a low zoom, the second one is hiding the first. But we have the same issue on the ManageTrainSchedule map. We should check that with @thibautsailly to fix it in another PR for both maps.

@Akctarus Akctarus requested a review from SharglutDev November 25, 2024 10:08
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 25, 2024
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@Akctarus Akctarus force-pushed the tmn/front/simulation-results-maps-vias branch from ac1634d to 4eb02ab Compare November 26, 2024 10:24
@Akctarus Akctarus force-pushed the tmn/front/simulation-results-maps-vias branch from 4eb02ab to d4ade2e Compare November 26, 2024 10:24
@Akctarus Akctarus enabled auto-merge November 26, 2024 10:24
@Akctarus Akctarus added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit a35f602 Nov 26, 2024
27 checks passed
@Akctarus Akctarus deleted the tmn/front/simulation-results-maps-vias branch November 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vias icon in scenario map
3 participants