core: disable colors when the output isn't compatible #9576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9576 +/- ##
============================================
- Coverage 42.50% 42.49% -0.01%
Complexity 2272 2272
============================================
Files 1312 1312
Lines 105588 105588
Branches 3304 3304
============================================
- Hits 44881 44872 -9
- Misses 58754 58763 +9
Partials 1953 1953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Khoyo
approved these changes
Nov 5, 2024
eckter
force-pushed
the
ech/core-disable-colors
branch
from
ff7ba26 to
dfeb879
Compare
Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/core-disable-colors
branch
from
dfeb879 to
eab53d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should leave colors in a tty but remove them from datadog and such