-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: multithread core workers #9591
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9591 +/- ##
============================================
- Coverage 42.50% 42.49% -0.02%
Complexity 2272 2272
============================================
Files 1312 1312
Lines 105588 105608 +20
Branches 3304 3305 +1
============================================
- Hits 44881 44873 -8
- Misses 58754 58782 +28
Partials 1953 1953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Does this do parallel consume? Or does this launch a single task on the threadpool (and we would need to actually call consume multiple times on separate channels?) |
8050c30
to
70e728b
Compare
The "consume" is only done on a single thread, but the processing itself is dispatched to the executor. The alternative would be to create several channels and call several consumes, but I struggled to make it work and to have it actually work in parallel. (But I can try again later if the current solution bothers anyone) |
Signed-off-by: Eloi Charpentier <[email protected]>
70e728b
to
f228935
Compare
Fix #9572
Configurable with a
WORKER_THREADS=42
env variable, with a default set to the number of processors.