Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: actually remove the port mapping in host mode #9603

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 6, 2024

No description provided.

@Khoyo Khoyo requested a review from a team as a code owner November 6, 2024 16:43
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(For future reference, docs for this: https://docs.docker.com/reference/compose-file/merge/#reset-value)

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (12d51f2) to head (d5e181c).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9603      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.02%     
  Complexity     2271     2271              
============================================
  Files          1311     1311              
  Lines        105411   105413       +2     
  Branches       3296     3297       +1     
============================================
- Hits          44815    44802      -13     
- Misses        58650    58665      +15     
  Partials       1946     1946              
Flag Coverage Δ
core 75.05% <ø> (-0.02%) ⬇️
editoast 73.66% <ø> (-0.05%) ⬇️
front 18.79% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
Could you also add a commit to remove all version: '3' from the docker compose files since its deprecated in this PR ? (It's just, I'm thinking about doing a PR specifically for this for some time and it can fit this PR).

@Khoyo Khoyo enabled auto-merge November 7, 2024 12:03
@Khoyo Khoyo added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@Khoyo Khoyo added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit 1bd519d Nov 7, 2024
24 checks passed
@Khoyo Khoyo deleted the yk/host-no-port-mapp branch November 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants