Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix the number of loading states #9607

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 6, 2024

Closes #8410.

@Khoyo Khoyo requested a review from a team as a code owner November 6, 2024 20:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.82%. Comparing base (432baa4) to head (c1b88c5).
Report is 100 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9607      +/-   ##
==========================================
- Coverage   37.84%   37.82%   -0.02%     
==========================================
  Files         990      990              
  Lines       90918    90920       +2     
  Branches     1176     1176              
==========================================
- Hits        34411    34394      -17     
- Misses      56053    56072      +19     
  Partials      454      454              
Flag Coverage Δ
editoast 73.21% <ø> (-0.07%) ⬇️
front 20.11% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Nov 6, 2024

To avoid hardcoding this number in each locale, could we maybe pass it as argument?

But TBH there's nothing locale-specific here, so could we just drop that from translations maybe?

In any case, this LGTM.

@Khoyo Khoyo force-pushed the yk/fix-infra-loading-states branch from d7ed731 to f03d541 Compare November 7, 2024 14:55
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently my ramblings have been sent directly to /dev/null. I've been pressured into approving this.

@Khoyo Khoyo enabled auto-merge November 15, 2024 15:28
@Khoyo Khoyo force-pushed the yk/fix-infra-loading-states branch from f03d541 to c1b88c5 Compare November 15, 2024 15:28
@Khoyo Khoyo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit 7a10b2c Nov 26, 2024
27 checks passed
@Khoyo Khoyo deleted the yk/fix-infra-loading-states branch November 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display infrastructure status in the frontend
3 participants