Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast, gateway, osrdyne: add more resources for OpenTelemetry #9609

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

woshilapin
Copy link
Contributor

Resource detectors will automatically populate a lot of information in
OpenTelemetry, especially, the EnvResourceDetector will parse
environment variables like OTEL_RESOURCE_ATTRIBUTES.

🔍 first commit is the interesting one, second commit is only about unmerging use imports

@woshilapin woshilapin requested review from a team as code owners November 6, 2024 23:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.83%. Comparing base (cb99790) to head (c59db0f).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9609      +/-   ##
==========================================
- Coverage   37.84%   37.83%   -0.01%     
==========================================
  Files         990      990              
  Lines       90915    90920       +5     
  Branches     1176     1176              
==========================================
- Hits        34404    34403       -1     
- Misses      56057    56063       +6     
  Partials      454      454              
Flag Coverage Δ
editoast 73.24% <ø> (-0.01%) ⬇️
front 20.11% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Resource detectors will automatically populate a lot of information in
OpenTelemetry, especially, the `EnvResourceDetector` will parse
environment variables like `OTEL_RESOURCE_ATTRIBUTES`.

Signed-off-by: Jean SIMARD <[email protected]>
@woshilapin woshilapin force-pushed the wsl/telemetry-resources branch from a4f6434 to aee90af Compare November 15, 2024 13:58
@woshilapin woshilapin enabled auto-merge November 15, 2024 13:59
@woshilapin woshilapin force-pushed the wsl/telemetry-resources branch from aee90af to c59db0f Compare November 15, 2024 15:47
@woshilapin woshilapin added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit b100495 Nov 15, 2024
27 checks passed
@woshilapin woshilapin deleted the wsl/telemetry-resources branch November 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants