Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add context to logged exceptions #9621

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 7, 2024

I just found myself seeing an exception in core logs, and I really wanted to read the included context

@eckter eckter requested a review from a team as a code owner November 7, 2024 10:37
@eckter eckter requested a review from Khoyo November 7, 2024 10:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.52%. Comparing base (1bd519d) to head (2ce84d8).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9621      +/-   ##
============================================
- Coverage     42.53%   42.52%   -0.02%     
- Complexity     2271     2272       +1     
============================================
  Files          1311     1311              
  Lines        105459   105460       +1     
  Branches       3297     3297              
============================================
- Hits          44860    44848      -12     
- Misses        58653    58666      +13     
  Partials       1946     1946              
Flag Coverage Δ
core 75.05% <100.00%> (+<0.01%) ⬆️
editoast 73.73% <ø> (-0.05%) ⬇️
front 18.79% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@Khoyo Khoyo force-pushed the ech/detail-errors-in-logs branch from 3c868a3 to 2ce84d8 Compare November 7, 2024 14:30
@Khoyo Khoyo enabled auto-merge November 7, 2024 14:30
@Khoyo Khoyo added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit a92037a Nov 7, 2024
25 checks passed
@Khoyo Khoyo deleted the ech/detail-errors-in-logs branch November 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants