front: fix stdcm conflicts not being properly displayed #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9631 +/- ##
============================================
- Coverage 42.51% 42.50% -0.02%
Complexity 2271 2271
============================================
Files 1311 1311
Lines 105413 105410 -3
Branches 3297 3297
============================================
- Hits 44812 44800 -12
- Misses 58655 58664 +9
Partials 1946 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The display of stdcm results is depending on the presence of path propertie coming from the stdcm response path. PathProperties was saved only if the stdcm response was success, not with conflicts status. Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
pfn/front/fix-stdcm-conflicts
branch
from
6fe9dc4 to
f49fdcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display of stdcm results is depending on the presence of path propertie coming from the stdcm response path. PathProperties was saved only if the stdcm response was success, not with conflicts status.
fix #9628