front: stdcm: fix time interpolation in output table #9640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/fix-stdcm-output-interpolation
branch
from
c5c9dac to
c9a2096
Compare
The back-end returns sparse data for time per position and expects the front-end to interpolate, but we didn't. The results were significantly off. This fixes both the table displayed in the result page and the one in the pdf file. Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/fix-stdcm-output-interpolation
branch
from
c9a2096 to
6bceef8
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9640 +/- ##
============================================
- Coverage 42.51% 42.51% -0.01%
Complexity 2272 2272
============================================
Files 1312 1312
Lines 105555 105563 +8
Branches 3304 3304
============================================
- Hits 44879 44875 -4
- Misses 58723 58735 +12
Partials 1953 1953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9626
The back-end returns sparse data for time per position and expects the front-end to interpolate, but we didn't. The results were significantly off.
This fixes both the table displayed in the result page and the one in the pdf file.