Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add a new updateMap() function to DistanceRangeMap #9659

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 8, 2024

The old one is now called updateMapIntersection(). The new one inserts the non overlapping ranges without modification.

@Khoyo Khoyo requested a review from a team as a code owner November 8, 2024 14:03
@Khoyo Khoyo requested a review from eckter November 8, 2024 14:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (deac2f4) to head (25026ac).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9659      +/-   ##
==========================================
- Coverage   38.21%   38.16%   -0.06%     
==========================================
  Files         995      996       +1     
  Lines       91912    92033     +121     
  Branches     1193     1192       -1     
==========================================
- Hits        35128    35127       -1     
- Misses      56329    56450     +121     
- Partials      455      456       +1     
Flag Coverage Δ
editoast 73.28% <ø> (-0.06%) ⬇️
front 20.18% <ø> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo force-pushed the yk/range-map-intersect branch 3 times, most recently from 1cd8430 to 4a69838 Compare November 8, 2024 14:22
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, gets the work done :)

The old own is now called updateMapIntersection(). The new one inserts
the non overlapping ranges without modification.

Signed-off-by: Younes Khoudli <[email protected]>
@Khoyo Khoyo force-pushed the yk/range-map-intersect branch from 4a69838 to 25026ac Compare November 28, 2024 11:50
@github-actions github-actions bot added the area:core Work on Core Service label Nov 28, 2024
@Khoyo Khoyo enabled auto-merge November 28, 2024 11:50
@Khoyo Khoyo added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit 2520f67 Nov 28, 2024
28 checks passed
@Khoyo Khoyo deleted the yk/range-map-intersect branch November 28, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants