Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: fix typo #9714

Merged
merged 1 commit into from
Nov 15, 2024
Merged

front: stdcm: fix typo #9714

merged 1 commit into from
Nov 15, 2024

Conversation

louisgreiner
Copy link
Contributor

Fix typo, see Mock-up :

image

@louisgreiner louisgreiner requested a review from a team as a code owner November 14, 2024 10:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.49%. Comparing base (6600f73) to head (c7662b0).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9714   +/-   ##
=========================================
  Coverage     42.48%   42.49%           
  Complexity     2272     2272           
=========================================
  Files          1312     1312           
  Lines        105608   105608           
  Branches       3305     3305           
=========================================
+ Hits          44869    44877    +8     
+ Misses        58786    58778    -8     
  Partials       1953     1953           
Flag Coverage Δ
core 74.95% <ø> (ø)
editoast 73.71% <ø> (+0.02%) ⬆️
front 18.79% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

Pedantic note: "LMR" is not used in the open-source project, "STDCM" remains used there. "LMR" is strictly an SNCF-specific name.

Copy link
Contributor

@JulesPeignier JulesPeignier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@emersion
Copy link
Member

It seems like your commit is missing a S-o-b trailer :P

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@louisgreiner louisgreiner changed the title front: lmr: fix typo front: stdcm: fix typo Nov 14, 2024
@clarani
Copy link
Contributor

clarani commented Nov 15, 2024

You need to signup your commit ;)

Signed-off-by: Louis Greiner <[email protected]>
@louisgreiner louisgreiner added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit 5ae9934 Nov 15, 2024
27 checks passed
@louisgreiner louisgreiner deleted the lgr/lmr-fix-typo branch November 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants