-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: hide manchette op list edition button in stdcm debug #9715
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9715 +/- ##
============================================
- Coverage 42.50% 42.48% -0.02%
Complexity 2272 2272
============================================
Files 1312 1312
Lines 105588 105612 +24
Branches 3304 3305 +1
============================================
- Hits 44881 44871 -10
- Misses 58754 58788 +34
Partials 1953 1953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdb6bd2
to
524a989
Compare
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
524a989
to
c3ec317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from one nit, feel free to resolve it!
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
- Add a props to choose to display or not the op list's edition button in manchetteWithSpacetimeChart header Signed-off-by: Math_R_ <[email protected]>
c3ec317
to
7b9b0de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
close #9457