Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: hide manchette op list edition button in stdcm debug #9715

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Nov 14, 2024

close #9457

@Math-R Math-R requested a review from a team as a code owner November 14, 2024 14:50
@Math-R Math-R self-assigned this Nov 14, 2024
@Math-R Math-R requested review from Yohh and clarani November 14, 2024 14:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.48%. Comparing base (f05eecf) to head (524a989).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 10 Missing ⚠️
...tdcm/components/StdcmResults/StdcmDebugResults.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9715      +/-   ##
============================================
- Coverage     42.50%   42.48%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105588   105612      +24     
  Branches       3304     3305       +1     
============================================
- Hits          44881    44871      -10     
- Misses        58754    58788      +34     
  Partials       1953     1953              
Flag Coverage Δ
core 74.95% <ø> (-0.11%) ⬇️
editoast 73.69% <ø> (-0.04%) ⬇️
front 18.79% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Math-R Math-R force-pushed the mrd/hide-manchette-edition-button-in-stdcm-debug branch from bdb6bd2 to 524a989 Compare November 14, 2024 14:54
@Math-R Math-R force-pushed the mrd/hide-manchette-edition-button-in-stdcm-debug branch from 524a989 to c3ec317 Compare November 15, 2024 10:58
@Math-R Math-R requested a review from emersion November 15, 2024 10:59
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one nit, feel free to resolve it!

- Add a props to choose to display or not the op list's edition button in manchetteWithSpacetimeChart header

Signed-off-by: Math_R_ <[email protected]>
@Math-R Math-R force-pushed the mrd/hide-manchette-edition-button-in-stdcm-debug branch from c3ec317 to 7b9b0de Compare November 15, 2024 11:08
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Math-R Math-R added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit b9237b0 Nov 15, 2024
27 checks passed
@Math-R Math-R deleted the mrd/hide-manchette-edition-button-in-stdcm-debug branch November 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: button to edit the op list should not be displayed
4 participants