-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group cli to editoast #9734
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9734 +/- ##
==========================================
- Coverage 37.85% 37.80% -0.06%
==========================================
Files 990 992 +2
Lines 90928 91097 +169
Branches 1176 1176
==========================================
+ Hits 34423 34439 +16
- Misses 56051 56204 +153
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
7e2d564
to
de4f091
Compare
de4f091
to
bb0e0d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. A few comments about the interface:
- both
group include
andgroup exclude
accept an empty list of users andexit 0
without a warning of some sort - if a user ID provided to
group include
doesn't exist, the postgres error is the only one shown (insert or update on table "authn_group_membership" violates foreign key constraint "authn_group_membership_user_fkey"
) group exclude
doesn't check that the provided users actually exist and are in the group. In which case the command does nothing and exits 0.
Those remarks are not that important especially since this CLI should be merged fast, but I'd rather draw some attention to them just to be sure.
Signed-off-by: Florian Amsallem <[email protected]>
bb0e0d9
to
0d0dc3e
Compare
Add a bunch of commands to manage users and groups.
close #8754