-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: add jetbrain folder .idea to gitignore #9740
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9740 +/- ##
==========================================
- Coverage 37.85% 37.84% -0.01%
==========================================
Files 990 990
Lines 90921 90921
Branches 1176 1176
==========================================
- Hits 34415 34411 -4
- Misses 56052 56056 +4
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let's not bother too much with this imho |
You should probable add it to the |
Signed-off-by: Alice Khoudli <[email protected]>
c8ff907
to
c4b56a5
Compare
Removed it from core/.gitignore, but I don't believe there is such a thing as a general .dockerignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually right, oh well
Prevent files from jetbrain IDEs (datagrip, intellij, pycharm, webstorm, ...) from being tracked.
Jetbrain actually recommends part of the .idea folder to be shared via git and provides its own .gitignore for this purpose, but I'm not sure enough people use jetbrain in our project to warrant this.