Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add jetbrain folder .idea to gitignore #9740

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 16, 2024

Prevent files from jetbrain IDEs (datagrip, intellij, pycharm, webstorm, ...) from being tracked.

Jetbrain actually recommends part of the .idea folder to be shared via git and provides its own .gitignore for this purpose, but I'm not sure enough people use jetbrain in our project to warrant this.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.84%. Comparing base (8a2b4c9) to head (c8ff907).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9740      +/-   ##
==========================================
- Coverage   37.85%   37.84%   -0.01%     
==========================================
  Files         990      990              
  Lines       90921    90921              
  Branches     1176     1176              
==========================================
- Hits        34415    34411       -4     
- Misses      56052    56056       +4     
  Partials      454      454              
Flag Coverage Δ
editoast 73.27% <ø> (-0.02%) ⬇️
front 20.11% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar requested review from Khoyo and younesschrifi November 19, 2024 17:00
@ElysaSrc
Copy link
Member

Jetbrain actually recommends part of the .idea folder to be shared via git and provides its own .gitignore for this purpose, but I'm not sure enough people use jetbrain in our project to warrant this.

Let's not bother too much with this imho

@Khoyo
Copy link
Contributor

Khoyo commented Nov 19, 2024

You should probable add it to the .dockerignore and remove it from core/{.gitignore,.dockerignore}

@Synar Synar force-pushed the ali/add-jetbrains-files-to-gitignore branch from c8ff907 to c4b56a5 Compare November 20, 2024 13:03
@Synar Synar requested a review from a team as a code owner November 20, 2024 13:03
@github-actions github-actions bot added the area:core Work on Core Service label Nov 20, 2024
@Synar
Copy link
Contributor Author

Synar commented Nov 20, 2024

You should probable add it to the .dockerignore and remove it from core/{.gitignore,.dockerignore}

Removed it from core/.gitignore, but I don't believe there is such a thing as a general .dockerignore

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually right, oh well

@Synar Synar added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 57c96f7 Nov 20, 2024
27 checks passed
@Synar Synar deleted the ali/add-jetbrains-files-to-gitignore branch November 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants