front: use matchPathStepAndOp() in TimesStopsInput's clearPathStep() #9756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I haven't had the chance to test it yet, but the old way was indeed quite complex and flaky. |
SharglutDev
reviewed
Nov 19, 2024
We already have a function which matches an OP and a path step. Re-use it instead of hand-rolling our own logic. In the UIC case, match by positionOnPath instead of name: this should be more robust. In the track offset case, drop the opId check because track offsets never have an OP ID. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/simplify-rm-via
branch
from
e98e6ee to
f0ea907
Compare
emersion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a function which matches an OP and a path step.
Re-use it instead of hand-rolling our own logic.
In the UIC case, match by positionOnPath instead of name: this
should be more robust. In the track offset case, drop the opId
check because track offsets never have an OP ID.