front: leave ch code null when unspecified in XML import #9763
Conversation
An empty string will specifically select OPs without any secondary code. However that's very unlikely that's what the user wants: in the French infrastructure, all OPs have a secondary code. Instead, use undefined to match any secondary code. While at it, drop the empty string default for ciCode: this is always guaranteed to be a string (because split() always returns an array with at least one element) so it's dead code. Signed-off-by: Simon Ser <[email protected]>
This is unconditionally converted to a number later on (when turning it into a UIC). We don't need to store this as a string. Signed-off-by: Simon Ser <[email protected]>
|
Does that mean we don't want the OP to appear in the pathSteps, but only in the "allWaypoints", in case the ch code isn't specified in the xml file ? this is before removing the ch code for la freissinouse : this is after removing it : |
This sounds like a separate, orthogonal bug: when I believe this bug happens on the |
You're absolutely right, this bug is indeed already present on the dev branch. It seems this bug ticket track it |
An empty string will specifically select OPs without any secondary
code. However that's very unlikely that's what the user wants: in
the French infrastructure, all OPs have a secondary code. Instead,
use undefined to match any secondary code.
While at it, drop the empty string default for ciCode: this is
always guaranteed to be a string (because split() always returns
an array with at least one element) so it's dead code.
To test: edit an XML file to remove a ch code (e.g. replace
SG/BVwithSG), then import it.Also includes a cleanup commit.