Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use matchPathStepAndOp() in upsertPathStepsInOPs() #9764

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

emersion
Copy link
Member

matchPathStepAndOp() is more general than special-casing UICs. It should make upsertPathStepsInOPs() work even if steps are defined in terms of trigrams or OP IDs.

matchPathStepAndOp() is more general than special-casing UICs. It
should make upsertPathStepsInOPs() work even if steps are defined
in terms of trigrams or OP IDs.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested review from clarani and Caracol3 November 18, 2024 16:46
@emersion emersion requested a review from a team as a code owner November 18, 2024 16:46
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@emersion emersion added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit 460c405 Nov 26, 2024
27 checks passed
@emersion emersion deleted the emr/match-upsert-path-steps-in-ops branch November 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants