Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix speed limit tags for stdcm #9778

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix speed limit tags for stdcm #9778

merged 1 commit into from
Nov 19, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Nov 19, 2024

The list of speed limits was invalid for STDCM.

close #9682

@flomonster flomonster requested a review from a team as a code owner November 19, 2024 10:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.86%. Comparing base (e0ec0fc) to head (11f532e).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9778      +/-   ##
==========================================
- Coverage   37.88%   37.86%   -0.02%     
==========================================
  Files         992      992              
  Lines       90973    90965       -8     
  Branches     1176     1176              
==========================================
- Hits        34461    34441      -20     
- Misses      56058    56070      +12     
  Partials      454      454              
Flag Coverage Δ
editoast 73.28% <ø> (-0.07%) ⬇️
front 20.11% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SharglutDev
Copy link
Contributor

SharglutDev commented Nov 19, 2024

There might an intersection with this issue ? #9682

Do you want to take care of it ?

@SharglutDev SharglutDev self-requested a review November 19, 2024 10:14
Copy link

@maelysLeratRosso maelysLeratRosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flomonster
Copy link
Contributor Author

There might an intersection with this issue ? #9682

Do you want to take care of it ?

After discussion with @bougue-pe, we don't need to check speed limit tags in the infra for STDCM. We only need a fixed list. For now the list is hardcoded, late it will be nice to handle it in the backend.

@flomonster flomonster added this pull request to the merge queue Nov 19, 2024
Merged via the queue into dev with commit 535d81d Nov 19, 2024
27 checks passed
@flomonster flomonster deleted the fam/fix-code-stdcm branch November 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: front: shorten the composition code list by only using the ones from the LMR infrastructure
6 participants