-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix speed limit tags for stdcm #9778
Conversation
Signed-off-by: Florian Amsallem <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9778 +/- ##
==========================================
- Coverage 37.88% 37.86% -0.02%
==========================================
Files 992 992
Lines 90973 90965 -8
Branches 1176 1176
==========================================
- Hits 34461 34441 -20
- Misses 56058 56070 +12
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There might an intersection with this issue ? #9682 Do you want to take care of it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After discussion with @bougue-pe, we don't need to check speed limit tags in the infra for STDCM. We only need a fixed list. For now the list is hardcoded, late it will be nice to handle it in the backend. |
The list of speed limits was invalid for STDCM.
close #9682