Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdcm display stop type even when CI and CH are not set #9781

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

achrafmohye
Copy link
Contributor

@achrafmohye achrafmohye commented Nov 19, 2024

Closes #9577

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.87%. Comparing base (a4daa6d) to head (991f752).
Report is 27 commits behind head on dev.

Files with missing lines Patch % Lines
...lications/stdcm/components/StdcmForm/StdcmVias.tsx 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9781      +/-   ##
==========================================
+ Coverage   37.85%   37.87%   +0.01%     
==========================================
  Files         990      992       +2     
  Lines       90928    90963      +35     
  Branches     1176     1176              
==========================================
+ Hits        34423    34453      +30     
- Misses      56051    56056       +5     
  Partials      454      454              
Flag Coverage Δ
editoast 73.32% <ø> (+0.01%) ⬆️
front 20.11% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@achrafmohye achrafmohye marked this pull request as ready for review November 19, 2024 14:53
@achrafmohye achrafmohye requested a review from a team as a code owner November 19, 2024 14:53
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM !

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job :)

@achrafmohye achrafmohye added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 83fbe09 Nov 20, 2024
27 checks passed
@achrafmohye achrafmohye deleted the ame/fix-stdcm-display-stop-type branch November 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: display stop type even when CI and CH are not set
5 participants