front: fix typing in i18n-api-errors script #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/i18n-api-errors.ts directly uses this package, but it was missing from package.json. We were getting it by chance as a transitive dependency. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/fix-i18n-api-errors-typing
branch
from
c6ce0d5 to
f3dd0c2
Compare
SharglutDev
reviewed
Nov 19, 2024
The openapi-types package is a peerDependency of @apidevtools/swagger-parser. yarn doesn't install peerDependencies by default. This is an issue because when openapi-types is missing, TypeScript doesn't have any typing information about the values returned by SwaggerParser.validate(), and assumes `any`. This results in type checking getting completely disabled for code manipulating the return value. Indeed, after installing openapi-types, `yarn build` indicates TypeScript errors in i18n-api-errors.ts. Fix these errors by checking that the returned schema is OpenAPI (as opposed to Swagger), and that `EditoastError` is a schema object. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/fix-i18n-api-errors-typing
branch
from
f3dd0c2 to
6ebee0f
Compare
Yohh
approved these changes
Nov 19, 2024
SharglutDev
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Prerequisite for switching to NPM.