-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: display timetable in macro mode, add styles for macro container #9792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested good work just a few comments
front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9792 +/- ##
==========================================
- Coverage 79.84% 79.84% -0.01%
==========================================
Files 1048 1048
Lines 105055 105038 -17
Branches 756 756
==========================================
- Hits 83885 83865 -20
- Misses 21129 21132 +3
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
Outdated
Show resolved
Hide resolved
aba32b0
to
9f3365d
Compare
front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
a14e100
to
991635e
Compare
Signed-off-by: romainvalls <[email protected]>
991635e
to
9b41940
Compare
Part 1 of https://github.com/orgs/osrd-project/projects/12/views/1?pane=issue&itemId=85192975&issue=osrd-project%7Cosrd-confidential%7C840
At the moment, we only display the timetable in macro mode, without being able to edit the trains.
We will focus on editing the trains in the second part.