Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display timetable in macro mode, add styles for macro container #9792

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

RomainValls
Copy link
Contributor

Part 1 of https://github.com/orgs/osrd-project/projects/12/views/1?pane=issue&itemId=85192975&issue=osrd-project%7Cosrd-confidential%7C840

At the moment, we only display the timetable in macro mode, without being able to edit the trains.
We will focus on editing the trains in the second part.

@RomainValls RomainValls added area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module labels Nov 20, 2024
@RomainValls RomainValls requested a review from a team as a code owner November 20, 2024 13:55
@RomainValls RomainValls self-assigned this Nov 20, 2024
@github-actions github-actions bot removed the area:front Work on Standard OSRD Interface modules label Nov 20, 2024
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested good work just a few comments

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (52c374b) to head (9b41940).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9792      +/-   ##
==========================================
- Coverage   79.84%   79.84%   -0.01%     
==========================================
  Files        1048     1048              
  Lines      105055   105038      -17     
  Branches      756      756              
==========================================
- Hits        83885    83865      -20     
- Misses      21129    21132       +3     
  Partials       41       41              
Flag Coverage Δ
editoast 73.36% <ø> (-0.01%) ⬇️
front 89.34% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-display-timetable-in-macro-mode branch 3 times, most recently from aba32b0 to 9f3365d Compare November 29, 2024 10:59
@emersion emersion self-requested a review December 2, 2024 14:48
@RomainValls RomainValls requested a review from emersion December 3, 2024 09:36
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RomainValls RomainValls force-pushed the rvs/front-display-timetable-in-macro-mode branch from a14e100 to 991635e Compare December 4, 2024 16:39
@RomainValls RomainValls added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@RomainValls RomainValls added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@RomainValls RomainValls added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@RomainValls RomainValls force-pushed the rvs/front-display-timetable-in-macro-mode branch from 991635e to 9b41940 Compare December 5, 2024 10:40
@RomainValls RomainValls added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 419a315 Dec 5, 2024
27 checks passed
@RomainValls RomainValls deleted the rvs/front-display-timetable-in-macro-mode branch December 5, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants