-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix stdcm rolling stock image display #9796
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9796 +/- ##
==========================================
+ Coverage 37.79% 38.20% +0.40%
==========================================
Files 994 995 +1
Lines 91185 91893 +708
Branches 1174 1189 +15
==========================================
+ Hits 34464 35108 +644
- Misses 56267 56331 +64
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the last comment from @thibautsailly on the issue (padding and gradient), it works great !
801eba1
to
84f2585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested :)
There doesn't seems to be a fading on the left of the image Is it the desired effect @thibautsailly ? |
Signed-off-by: Theo Macron <[email protected]>
79c868c
to
4a680c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
closes #8289