Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stdcm rolling stock image display #9796

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Akctarus
Copy link
Contributor

closes #8289

@Akctarus Akctarus requested a review from a team as a code owner November 20, 2024 16:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (b4dd722) to head (4a680c9).
Report is 53 commits behind head on dev.

Files with missing lines Patch % Lines
...lications/stdcm/components/StdcmForm/StdcmCard.tsx 0.00% 1 Missing ⚠️
...ations/stdcm/components/StdcmForm/StdcmConsist.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9796      +/-   ##
==========================================
+ Coverage   37.79%   38.20%   +0.40%     
==========================================
  Files         994      995       +1     
  Lines       91185    91893     +708     
  Branches     1174     1189      +15     
==========================================
+ Hits        34464    35108     +644     
- Misses      56267    56331      +64     
  Partials      454      454              
Flag Coverage Δ
editoast 73.27% <ø> (+0.25%) ⬆️
front 20.23% <0.00%> (+0.14%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the last comment from @thibautsailly on the issue (padding and gradient), it works great !

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 25, 2024
@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-rs-img branch 2 times, most recently from 801eba1 to 84f2585 Compare November 25, 2024 13:45
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@SharglutDev
Copy link
Contributor

There doesn't seems to be a fading on the left of the image

Capture d’écran 2024-11-26 à 11 35 32

Is it the desired effect @thibautsailly ?

@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-rs-img branch from 79c868c to 4a680c9 Compare November 27, 2024 08:58
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@theocrsb theocrsb added this pull request to the merge queue Nov 27, 2024
Merged via the queue into dev with commit fa8120d Nov 27, 2024
27 checks passed
@theocrsb theocrsb deleted the tmn/front/fix-stdcm-rs-img branch November 27, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1TGVDUPL livery is weird in the tab
4 participants