Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: simplify timestampToHHMMSS() #9817

Merged
merged 1 commit into from
Nov 25, 2024
Merged

front: simplify timestampToHHMMSS() #9817

merged 1 commit into from
Nov 25, 2024

Conversation

emersion
Copy link
Member

Instead of manually extracting what we want from a larger string with string offsets, format the date.

Instead of manually extracting what we want from a larger string
with string offsets, format the date.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested review from Synar and clarani November 21, 2024 17:08
@emersion emersion requested a review from a team as a code owner November 21, 2024 17:08
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 21, 2024
Copy link
Contributor

@Synar Synar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@emersion emersion added this pull request to the merge queue Nov 25, 2024
Merged via the queue into dev with commit d493d7e Nov 25, 2024
27 checks passed
@emersion emersion deleted the emr/simplify-hh-mm-ss branch November 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants