Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add compatibility for G1 train gauge with FR3.3 track gauge #9824

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

bougue-pe
Copy link
Contributor

Based on:

  • G1 (PPI, literally "pass-everywhere international gauge") is the minimal gauge (see https://en.wikipedia.org/wiki/Loading_gauge)
  • the description from internal doc: "FR3.3 englobe le G1 pour des paramètres de circulations égaux."

Some doc is referenced in https://github.com/osrd-project/osrd-dags/issues/300

@bougue-pe bougue-pe requested review from eckter and axrolld November 22, 2024 14:29
@bougue-pe bougue-pe requested a review from a team as a code owner November 22, 2024 14:29
@github-actions github-actions bot added the area:core Work on Core Service label Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.79%. Comparing base (28c965c) to head (6484ae3).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #9824   +/-   ##
=======================================
  Coverage   37.79%   37.79%           
=======================================
  Files         994      994           
  Lines       91192    91192           
  Branches     1176     1176           
=======================================
  Hits        34468    34468           
  Misses      56270    56270           
  Partials      454      454           
Flag Coverage Δ
editoast 73.00% <ø> (ø)
front 20.09% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Based on:
* G1 (PPI, literally "pass-everywhere international gauge") is the minimal
  gauge (see https://en.wikipedia.org/wiki/Loading_gauge)
* the description from internal doc: "FR3.3 englobe le G1 pour des
  paramètres de circulations égaux."

Some doc is referenced in
osrd-project/osrd-dags#300

Signed-off-by: Pierre-Etienne Bougué <[email protected]>
@bougue-pe bougue-pe force-pushed the peb/core/gauge_track_fr33_compatible_with_train_g1 branch from 6c890ce to 6484ae3 Compare November 22, 2024 14:37
Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wise man once said : "G1 trains drive everywhere !"

@bougue-pe bougue-pe added this pull request to the merge queue Nov 25, 2024
Merged via the queue into dev with commit 1ef4572 Nov 25, 2024
27 checks passed
@bougue-pe bougue-pe deleted the peb/core/gauge_track_fr33_compatible_with_train_g1 branch November 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants